feat(trezor): add Trezor hardware wallet integration via trezor-connect-rs#71
Open
coreyphillips wants to merge 3 commits intomasterfrom
Open
feat(trezor): add Trezor hardware wallet integration via trezor-connect-rs#71coreyphillips wants to merge 3 commits intomasterfrom
coreyphillips wants to merge 3 commits intomasterfrom
Conversation
…ct-rs Rewrite the Trezor hardware wallet module to use trezor-connect-rs. Includes the following functionality: - get address - get xpub - sign/verify messages - sign transaction
… P2PKH support - Add trezor_sign_tx_from_psbt() for PSBT-based transaction signing - Add trezor_get_device_fingerprint() for output descriptor construction - Wire TrezorUiCallback into ConnectedDevice for PIN/passphrase prompts - Remove on_button_request from TrezorUiCallback (handled internally) - Remove dead trezor_init_ble() export - Add TrezorPrevTx types and enable P2PKH (legacy) input signing - Add orig_hash/orig_index fields for RBF replacement transactions - Add structural validation for TrezorTxOutput (exclusive mode check) - Fix transport type detection to use cached enum instead of string heuristic - Fix panic at FFI boundary by converting JoinError to TrezorError::IoError
ben-kaufman
reviewed
Feb 20, 2026
src/modules/trezor/implementation.rs
Outdated
| } | ||
|
|
||
| // Check if it's hardened (ends with ') | ||
| let num_str = if component.ends_with('\'') { |
Collaborator
There was a problem hiding this comment.
Hardened path may also use h innsteaad of '
|
|
||
| /// Script types for address derivation. | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, uniffi::Enum)] | ||
| pub enum TrezorScriptType { |
Collaborator
There was a problem hiding this comment.
Might want to add P2SH and P2WSH for future compatibility.
Collaborator
Author
There was a problem hiding this comment.
This is meant to mirror Trezor's InputScriptType variants where there are no dedicated P2SH or P2WSH types here: https://github.com/trezor/trezor-suite/blob/develop/packages/protobuf/messages.json#L3-L12
src/modules/trezor/types.rs
Outdated
| /// BIP32 path (e.g., "m/84'/0'/0'/0/0") | ||
| pub path: String, | ||
| /// Coin name (default: "Bitcoin") | ||
| pub coin: Option<String>, |
Collaborator
There was a problem hiding this comment.
We only ever want this to be Bitcoin (or BitcoinTestnet / Regtest if those are options), so I'd suggest to either remove or if testnet and/or regtest are different option make an enum for these.
… add External script type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
src/modules/trezor/) withtrezor-connect-rs, enabling device discovery, connection, and Bitcoin operations over USB and BluetoothSupported Operations
trezor_scantrezor_connect/trezor_disconnecttrezor_get_addresstrezor_get_public_keytrezor_sign_message/trezor_verify_messagetrezor_sign_txTesting