fix: probing tool validation and error messages#791
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Description
The probing tool now detects zero-amount bolt11 invoices and automatically uses 1 sat as the probe amount when the user doesn't specify one. Before sending a probe, the tool validates that the amount doesn't exceed the available outbound capacity and warns the user with the available balance. Probe failure messages are mapped from raw LDK errors to human-readable descriptions.
Preview
QA Notes
1. Zero-amount invoice probing
2. Outbound capacity validation
3. LNURL probing
4. Error message improvements
5. Verification
./gradlew compileDevDebugKotlin— compiles./gradlew testDevDebugUnitTest— all tests pass./gradlew detekt— no new lint issues