Repository navigation
[removal] Replace ForbiddenNodeRule with dedicated ForbiddenTraitRule and ForbiddenSwitchRule - #342
Merged
Merged
Conversation
…ule and ForbiddenSwitchRule
Contributor
|
This PR immediately broke our builds on release, as its a BC break hidden in a minor release |
Contributor
|
the projects readme promotes use of single rules by documentation like so I think removing rules should not happen in non-major releases |
Member
Author
|
Let me patch it. Use the old tag for now. How do you use it? |
Contributor
|
in the relevant case we are using a configurable rule like thank you |
Member
Author
|
Getting on subway, just a sec... |
Member
Author
|
Fixed: #346 Taggec 14.18.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ForbiddenNodeRulewas a single configurable rule banning 8 node types (traits, switch, empty(), @ suppression, string interpolation, post inc/dec) under one shared identifiersymplify.forbiddenNode. Two problems:ignoreErrorscannot silence a single node type.symplify.configurable: falsealso kills unrelated configurable rules.It also hid too much behind one opaque message with no reason or alternative.
What
ForbiddenNodeRuleand its generic node list.ForbiddenTraitRuleandForbiddenSwitchRule, each with its own identifier (symplify.forbiddenTrait,symplify.forbiddenSwitch) and a message that names the alternative.configurable-rules.neon(toggled bysymplify.configurable) andrector-rules.neon.Checks
ECS, PHPStan, Rector and PHPUnit all green.