Skip to content

Make insight.phar publicly accessible after release #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- uses: shivammathur/setup-php@v2
with:
php-version: '7.2'
tools: php-cs-fixer:3.2.1
tools: php-cs-fixer:3.4.0
coverage: none
- name: php-cs-fixer
run: php-cs-fixer fix --dry-run --diff
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/only-main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ jobs:

- name: Release
run: |
aws s3 cp build/insight.phar s3://get.insight.symfony.com/insight.phar
aws s3 cp build/insight.phar s3://get.insight.symfony.com/insight.phar --acl public-read
5 changes: 3 additions & 2 deletions Cli/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@

class Application extends SymfonyApplication
{
const APPLICATION_NAME = 'SymfonyInsight CLI';
const APPLICATION_VERSION = '1.7.4';
public const APPLICATION_NAME = 'SymfonyInsight CLI';

public const APPLICATION_VERSION = '1.7.4';

private $api;
private $apiConfig;
Expand Down
14 changes: 9 additions & 5 deletions Cli/Descriptor/PmdDescriptor.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,15 @@

class PmdDescriptor extends AbstractDescriptor
{
const PHPMD_PRIORITY_HIGH = 1;
const PHPMD_PRIORITY_MEDIUM_HIGH = 2;
const PHPMD_PRIORITY_MEDIUM = 3;
const PHPMD_PRIORITY_MEDIUM_LOW = 4;
const PHPMD_PRIORITY_LOW = 5;
public const PHPMD_PRIORITY_HIGH = 1;

public const PHPMD_PRIORITY_MEDIUM_HIGH = 2;

public const PHPMD_PRIORITY_MEDIUM = 3;

public const PHPMD_PRIORITY_MEDIUM_LOW = 4;

public const PHPMD_PRIORITY_LOW = 5;

protected function describeAnalysis(Analysis $analysis, array $options = [])
{
Expand Down
2 changes: 1 addition & 1 deletion Sdk/Api.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

class Api
{
const ENDPOINT = 'https://insight.symfony.com';
public const ENDPOINT = 'https://insight.symfony.com';

private $baseUrl;
private $httpClient;
Expand Down
14 changes: 9 additions & 5 deletions Sdk/Model/Analysis.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,15 @@

class Analysis
{
const STATUS_ORDERED = 'ordered';
const STATUS_RUNNING = 'running';
const STATUS_MEASURED = 'measured';
const STATUS_ANALYZED = 'analyzed';
const STATUS_FINISHED = 'finished';
public const STATUS_ORDERED = 'ordered';

public const STATUS_RUNNING = 'running';

public const STATUS_MEASURED = 'measured';

public const STATUS_ANALYZED = 'analyzed';

public const STATUS_FINISHED = 'finished';

/**
* @Type("array<SensioLabs\Insight\Sdk\Model\Link>")
Expand Down
29 changes: 19 additions & 10 deletions Sdk/Model/Project.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,25 @@ class Project
/**
* @see https://github.com/sensiolabs/connect/blob/master/src/SensioLabs/Connect/Api/Entity/Project.php
*/
const TYPE_PHP_WEBSITE = 0;
const TYPE_PHP_LIBRARY = 1;
const TYPE_SYMFONY2_BUNDLE = 2;
const TYPE_SYMFONY1_PLUGIN = 4;
const TYPE_OTHER = 6;
const TYPE_DRUPAL_MODULE = 7;
const TYPE_LARAVAL_WEB_PROJECT = 8;
const TYPE_SILEX_WEB_PROJECT = 9;
const TYPE_SYMFONY2_WEB_PROJECT = 10;
const TYPE_SYMFONY1_WEB_PROJECT = 11;
public const TYPE_PHP_WEBSITE = 0;

public const TYPE_PHP_LIBRARY = 1;

public const TYPE_SYMFONY2_BUNDLE = 2;

public const TYPE_SYMFONY1_PLUGIN = 4;

public const TYPE_OTHER = 6;

public const TYPE_DRUPAL_MODULE = 7;

public const TYPE_LARAVAL_WEB_PROJECT = 8;

public const TYPE_SILEX_WEB_PROJECT = 9;

public const TYPE_SYMFONY2_WEB_PROJECT = 10;

public const TYPE_SYMFONY1_WEB_PROJECT = 11;

/**
* @Exclude()
Expand Down
Loading