Skip to content

Autocomplete: Don't add plugins automaticly when defined #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Autocomplete: Don't add plugins automaticly when defined #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions src/Autocomplete/assets/src/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,21 @@ export default class extends Controller {
#getCommonConfig(): Partial<TomSettings> {
const plugins: any = {}

// multiple values excepted if this is NOT A select (i.e. input) or a multiple select
const isMultiple = !this.selectElement || this.selectElement.multiple;
if (!this.formElement.disabled && !isMultiple) {
plugins.clear_button = { title: '' };
}

if (isMultiple) {
plugins.remove_button = { title: '' };
}

if (this.urlValue) {
plugins.virtual_scroll = {};
// automaticly add plugins when NOT explicit configured
if (!this.tomSelectOptionsValue || !this.tomSelectOptionsValue.plugins !== undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line right? That extra ! in front of this.tomSelectOptionsValue.plugins looks funny to me.

I'd love to have a test for this. It would live in https://github.com/symfony/ux/blob/2.x/src/Autocomplete/assets/test/controller.test.ts. In the existing pre-connect listener - https://github.com/symfony/ux/blob/2.x/src/Autocomplete/assets/test/controller.test.ts#L23 - we could add:

this.element.tomSelectOptions = event.detail.options;

Then, we could add a test that passes a data-autocomplete-tom-select-options-value="{ plugins: { virtual_scroll: {} } }" and verify with something like getByTestId(container, 'main-element').tomSelectOptions.plugins.toBe({ virtual_scroll: {} }).

// multiple values excepted if this is NOT A select (i.e. input) or a multiple select
const isMultiple = !this.selectElement || this.selectElement.multiple;
if (!this.formElement.disabled && !isMultiple) {
plugins.clear_button = { title: '' };
}

if (isMultiple) {
plugins.remove_button = { title: '' };
}

if (this.urlValue) {
plugins.virtual_scroll = {};
}
}

const config: Partial<TomSettings> = {
Expand Down