Skip to content

Conversation

@kevinmade
Copy link

@kevinmade kevinmade commented Oct 28, 2025

Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? no
Issues Fix #853
License MIT

This PR adds support for liveProp union types in Live Components. Previously, using a union type would throw an exception. With this change LiveComponentMetadataFactory will be able to create liveProp metadata for union types, but will only work in combination with a custom hydrate and dehydrate implementation.

@carsonbot carsonbot added Feature New Feature LiveComponent Status: Needs Review Needs to be reviewed labels Oct 28, 2025
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for the contribution!

This new feature needs to be covered with some tests, and the CHANGELOG.md must be updated too.

Also, you only support the TypeInfo path and not the legacy PropertyInfo path, but I think that's fine.

@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Oct 29, 2025
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Oct 29, 2025
@kevinmade kevinmade requested a review from Kocal October 30, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New Feature LiveComponent Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LiveComponent] Support UnionTypes for LiveProps

3 participants