[DependencyInjection] Document the date_time and date_time_format env var processors #18835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
94noni
reviewed
Sep 7, 2023
| @@ -190,6 +190,12 @@ Symfony provides the following env var processors: | |||
| ``env(float:FOO)`` | |||
| Casts ``FOO`` to a float. | |||
|
|
|||
| ``env(date_time:FOO)`` | |||
There was a problem hiding this comment.
event if other example uses FOO, what about here use a real date_time value format ?
I mean is it the Y-m-d H:i:s ?
obviously, for env(int:FOO) we know int refers to what, but date time is more ambiguous and doc must be straightfroward
wdyt?
also, you must add a version added directive to document that such new processor have been added on sf v6.4 👍🏻
There was a problem hiding this comment.
Documentation updated to the latest implementation. I have added the "version added directives" and the usage examples to describe how to use the both processors. I think that the examples are sufficient and the FOO can stay in processor name to make the documentation consistent.
secit-pl
changed the title
|
Sorry upstream PR was rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs