[Finder] [Finder docs] Add early directory prunning filter support #18499
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
debug_is_dir_cache_from_readdir
branch
2 times, most recently
from
e3932d3 to
90e73a1
Compare
mvorisek
force-pushed
the
debug_is_dir_cache_from_readdir
branch
from
8d46e70 to
7c0c6c1
Compare
mvorisek
force-pushed
the
debug_is_dir_cache_from_readdir
branch
from
7c731f6 to
7f1bbea
Compare
Co-authored-by: Alexis Lefebvre <[email protected]>
mvorisek
force-pushed
the
debug_is_dir_cache_from_readdir
branch
from
7f1bbea to
4b08ee6
Compare
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Oct 11, 2023
…mvorisek) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Finder] Add early directory prunning filter support | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#18499 Filtering terminology first: - "exclude" - whole filesystem subtree is traversed, directories (and files) are excluded after, slow - "prune" - pruned directories are not traversed, fast Currently there is early directory prunning support possible, but with string patterns only, not even full regex is supported as the input is always quoted - https://github.com/symfony/symfony/blob/v6.2.12/src/Symfony/Component/Finder/Iterator/ExcludeDirectoryFilterIterator.php#L45. This PR adds early directory prunning with full callback support. Tested with VFS to assert the pruned directories are really not traversed and the count of IO syscalls is minimal. Commits ------- 840cb28 [Finder] Add early directory prunning filter support
javiereguiluz
added
Finder
and removed
Waiting Code Merge
carsonbot
changed the title
|
Michael, thanks for implementing this feature and providing the docs for it. Congrats also on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs