add support for override_url #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
weaverryan
changed the title
weaverryan
reviewed
Feb 18, 2021
|
doctrine/DoctrineBundle#1290 was merged in to 2.3 today - this recipe i believe is safe to merge in now |
jrushlow
changed the title
weaverryan
reviewed
Mar 17, 2021
weaverryan
reviewed
Mar 23, 2021
doctrine/doctrine-bundle/2.3/config/packages/test/doctrine.yaml
Outdated
Show resolved
Hide resolved
Nyholm
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
Thank you.
This diff is really small.
# /config/packages/doctrine.yaml
doctrine:
dbal:
+ override_url: true
url: '%env(resolve:DATABASE_URL)%'
# /config/packages/test/doctrine.yaml
+#doctrine:
+# dbal:
+# # Overrides the database name in the test environment only
+# # "host", "port", "username", & "password" can also be set to override their respective url parts
+# #
+# # If you're using ParaTest, "TEST_TOKEN" is set by ParaTest otherwise nothing is appended to the database name.
+# dbname: main_test%env(default::TEST_TOKEN)%
derrabus
approved these changes
Mar 24, 2021
|
Wohoo. Thank you @jrushlow |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
use_savepointsby default for Doctrine DBAL #1290 Merged into2.31290 proposes to add a new
doctrine.dbal.override_urlparam that will allow you to override parts of aDATABASE_URL.