Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update recipe for Contao 5.x #1760

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bytehead
Copy link
Contributor

@bytehead bytehead commented Mar 10, 2025

Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1760/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1760/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'contao/core-bundle:^5.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

contao/core-bundle

4.6 vs 5.0
diff --git a/contao/core-bundle/4.6/config/packages/contao_core.yaml b/contao/core-bundle/5.0/config/packages/contao_core.yaml
index 8e665be6..8969b8f2 100644
--- a/contao/core-bundle/4.6/config/packages/contao_core.yaml
+++ b/contao/core-bundle/5.0/config/packages/contao_core.yaml
@@ -1,3 +1,10 @@
 # See https://github.com/contao/core-bundle
 contao:
-    web_dir: "%kernel.project_dir%/public"
+    preview_script: '/preview.php'
+    upload_path: files
+    csrf_token_name: contao_csrf_token
+    pretty_error_screens: true
+
+when@dev:
+    contao:
+        pretty_error_screens: false
diff --git a/contao/core-bundle/4.6/post-install.txt b/contao/core-bundle/5.0/post-install.txt
index 5cb918eb..0bbf4653 100644
--- a/contao/core-bundle/4.6/post-install.txt
+++ b/contao/core-bundle/5.0/post-install.txt
@@ -6,7 +6,4 @@
   * Edit your config/security.yaml file and include all the
     necessary providers, firewalls and access control sections.
 
-  * Complete the installation by opening the /contao/install route
-    in your browser.
-
-Documentation: https://github.com/contao/core-bundle
+Documentation: https://docs.contao.org/dev/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant