Skip to content

Add recipe for FOSOAuthServerBundle #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
May 12, 2021
Merged

Add recipe for FOSOAuthServerBundle #1119

1 commit merged into from
May 12, 2021

Conversation

MatTheCat
Copy link
Contributor

Q A
License MIT

Follow-up of #364

Fixes FriendsOfSymfony/FOSOAuthServerBundle#501 and FriendsOfSymfony/FOSOAuthServerBundle#638

It is my first recipe so I may have missed some things.

FTR entities properties are protected because their parent’s are.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@MatTheCat
Copy link
Contributor Author

If I understand the error message correctly I cannot create a recipe for this package as it has dependencies based on the value of db_driver which is mandatory.

Could someone confirm?

@Nyholm
Copy link
Member

Nyholm commented May 12, 2021

If I understand the error message correctly I cannot create a recipe for this package as it has dependencies based on the value of db_driver which is mandatory.

It is fine. It is just Travis that wont run.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ghost ghost merged commit 1af11a8 into symfony:master May 12, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error requiring bundle from composer on SF4
2 participants