Add support for Symfony 8 #1724
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
symfony-8-support
branch
2 times, most recently
from
add0501 to
b83539a
Compare
javiereguiluz
approved these changes
Oct 23, 2025
Member
javiereguiluz
left a comment
javiereguiluz
left a comment
There was a problem hiding this comment.
The Maker Bundle is a key part of the Symfony ecosystem. It'd be great to make sure it's compatible with Symfony 8.0 before its release at the end of November 2025.
Thanks, Hugo, for kicking off this effort!
Contributor
|
hi! is there some other work to do in order to merge this PR? the build has expired, and I cannot see what are the failures, but it seems they are not related to Sf 8 |
Member
Author
|
Hey, I will rebase but AFAIK errors were not related to Symfony 8 |
Kocal
force-pushed
the
symfony-8-support
branch
from
b83539a to
d544e7e
Compare
Kocal
force-pushed
the
symfony-8-support
branch
from
6cd8ffc to
78b1647
Compare
Kocal
force-pushed
the
symfony-8-support
branch
from
15a0c02 to
5452880
Compare
acrobat
reviewed
Nov 7, 2025
Kocal
force-pushed
the
symfony-8-support
branch
from
507f491 to
7682ef7
Compare
…e/runner/work/maker-bundle/maker-bundle/tests/tmp/cache/maker_app_063515884b8136c7453355430b232d22_6.4/tests/GeneratedLiveComponentTest.php" error
Member
Author
|
Finally a green CI 🤩 The Symfony 8 job is failing because there is no symfony/skeleton package for Symfony 8, but it should be fine |
nicolas-grekas
approved these changes
Nov 8, 2025
mtarld
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same tests on Symfony <8.0 & 8.0.x-dev jobs are failing, that's fine but we should take some time to fix them