Skip to content

[Demo] Remove --strict to composer validate (using @dev for now on deps) #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jul 27, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues n/a
License MIT

As we're using unbounded deps for now (@dev), we cannot use --strict on composer validate.

@fabpot fabpot requested a review from chr-hertel as a code owner July 27, 2025 08:35
@fabpot
Copy link
Member Author

fabpot commented Jul 27, 2025

I'm not even sure this pipeline entry in composer.json is useful. AFAICS, it's not used anywhere and the php-cs-fixer line doesn't work either as there is no directory and no PHPCSFixer configuration file. As it's not used in the Github action workflows, maybe we can just remove it? @chr-hertel

@chr-hertel
Copy link
Member

That's mostly a left over from the demo being a standalone repository - missed to remove it, true

@fabpot
Copy link
Member Author

fabpot commented Jul 27, 2025

ok, removed.

@chr-hertel chr-hertel added the Demo Issues & PRs about the demo application label Jul 27, 2025
@chr-hertel chr-hertel changed the title Remove --strict to composer validate (using @dev for now on deps) [Demo] Remove --strict to composer validate (using @dev for now on deps) Jul 27, 2025
@chr-hertel
Copy link
Member

Thank you @fabpot.

@chr-hertel chr-hertel merged commit c5818a1 into symfony:main Jul 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Demo Issues & PRs about the demo application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants