-
-
Notifications
You must be signed in to change notification settings - Fork 41
[Platform] Add tooling support for ollama to allow agent and toolbox usage #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Platform] Add tooling support for ollama to allow agent and toolbox usage #211
Conversation
18409bb
to
e89ead3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I general this looks pretty clean and not like your first contribution here - thanks kicking this off - great work!
I made a few comments - can see where your thoughts are coming from - this is between those axis in Platform - working with two bridges.
And rolling out tool calling support to more bridges is def a new feature 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I general this looks pretty clean and not like your first contribution here - thanks kicking this off - great work!
ty :) likely not my last one. already looking into ollama embeddings
And rolling out tool calling support to more bridges is def a new feature 👍
anything more you need to have written out for a zero-ver? :D
Please rebase on main and adopt the changed test style, switching from |
e89ead3
to
22509a7
Compare
I rebased, changed the test and renamed the class. Anything more :) ? |
22509a7
to
341184a
Compare
341184a
to
bbca652
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This! Looks! Great! :)
I believe your regex model work deserves some simple unit testing, but will give it a local test already
Tested with mistral, deepseek and llama - works 👍 |
Great I will fix phpstan, rebase and we can get this merged. The new pull request for the model usage can follow after that :) |
And that unit test for |
Running a toolbox agent with ollama was not yet supported. This ensures, that tool messages and responses work with a locally hosted ollama instance. It seems not to be a fix as it was not meant to work and it is not really a mentionable feature as one could expect it to work like the others so I am not really sure to work where to add more content for humans. I tested it with the given new example in
examples/ollama/toolcall.php
.A current design decision had me struggling a bit. I was not yet able to solve in a good way the fact, that ollama itself cannot claim every model to have tool support. So someone who uses a model needs to know before its usage whether it has model support. This can be queried easily but the capabilities are part of the model, that you need to create before using the platform to query in the name of the model. So this is like hen-egg. If the model itself would not know its capabilities but there is a service, that has model and platform at hand, could evaluate it (and cache it). Is this something we want to establish?
Possible query: