Treat special case of Bool in promote_rule
#260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
reviewed
Apr 2, 2025
| @@ -82,6 +82,7 @@ Basic(x::Basic) = x | |||
| Base.promote_rule(::Type{Basic}, ::Type{S}) where {S<:Number} = Basic | |||
| Base.promote_rule(::Type{S}, ::Type{Basic}) where {S<:Number} = Basic | |||
| Base.promote_rule(::Type{S}, ::Type{Basic}) where {S<:AbstractIrrational} = Basic | |||
| Base.promote_rule(::Type{Bool}, ::Type{Basic}) = Basic | |||
There was a problem hiding this comment.
I'm not sure if we should promote true to 1 or True in SymEngine.
There was a problem hiding this comment.
Yeah, that is a good question. Right now, neither True or False values are exposed. If True, is there some idiomatic way to make an expression like this evaluate to a number?
julia> True = Basic();
julia> ccall((:bool_set_true, SymEngine.libsymengine), Nothing, (Ref{Basic},), True)
julia> v = Basic(4) + True
4 + True
julia> SymEngine.evalf(v)
ERROR: ArgumentError: symbolic value cannot be evaluated to a numeric value
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #146.