fix: update download url to support new link format #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the mongodb download urls have changed syntax a bit; see examples.
Should fix issue: #14
This PR updates how the download link is constructed to attempt to account for distribution and to correct linux architecture which was showing up as arm64 on an x86_64 machine but really should be considered aarch64 for the purposes of downloading.
A drawback to this is that mongodb has not published binaries for all mongo versions and distributions... For example ubuntu LTS 24.04, can only use mongo >= 8.x.x . That said, the alternative was no linux support at all. So I'll take it.
Tested on osx and ubuntu 24.04.