Skip to content

Conversation

@myrta2302
Copy link
Contributor

@myrta2302 myrta2302 commented Nov 19, 2025

📄 Description

This PR:

  • Adds a PopOut animation an renamed the animation file to pop.ts
  • Renames the animation set on tooltip, popover, and menu button from 'pop-in' to 'pop'
  • Updates the popovercontainer to use the closing animation

🔮 Design review

  • Design review done
  • No design review needed

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@myrta2302 myrta2302 linked an issue Nov 19, 2025 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

⚠️ No Changeset found

Latest commit: 9f46524

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 19, 2025

Related Previews

@myrta2302 myrta2302 changed the base branch from main to 6538-bug-fix-post-menu-animation November 20, 2025 13:51
@myrta2302 myrta2302 changed the base branch from 6538-bug-fix-post-menu-animation to main November 21, 2025 07:44
@myrta2302 myrta2302 changed the base branch from main to 6538-bug-fix-post-menu-animation November 21, 2025 07:44
@myrta2302 myrta2302 changed the base branch from 6538-bug-fix-post-menu-animation to main November 21, 2025 07:48
@myrta2302 myrta2302 changed the base branch from main to 6538-bug-fix-post-menu-animation November 21, 2025 07:48
@myrta2302 myrta2302 changed the base branch from 6538-bug-fix-post-menu-animation to main November 21, 2025 07:53
@myrta2302 myrta2302 changed the base branch from main to 6538-bug-fix-post-menu-animation November 21, 2025 07:53
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add close animation to the popovercontainer

3 participants