feat(components): update post-popovercontainer animation and fix menu trigger and focus delays #6579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b991e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
myrta2302
changed the title
oliverschuerch
requested changes
Nov 5, 2025
packages/components/src/components/post-popovercontainer/post-popovercontainer.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-popovercontainer/post-popovercontainer.tsx
Show resolved
Hide resolved
myrta2302
changed the title
myrta2302
added
needs: 🏓 dev roundtable
|
oliverschuerch
requested changes
Nov 21, 2025
| }; | ||
|
|
||
| function render(args: Args) { | ||
| console.log(args.animation); |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log(args.animation); |
| @Prop() menuLabel!: string; | ||
|
|
||
| /** | ||
| * |
Contributor
There was a problem hiding this comment.
Where is the description?
| } | ||
|
|
||
| /** | ||
| /**s |
Contributor
There was a problem hiding this comment.
Suggested change
| /**s | |
| /** |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
This PR follows #6606:
post-popovercontainerto open with animation only when animation is set to 'pop-in'.post-menuto handle focus and aria-expanded on the trigger inpostBeforeToggleinstead ofpostToggled, fixing related delays.🔮 Design review
📝 Checklist