Information when a unit type does not exist #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when running lesson_to_html() a unit type (class) that does not exist results in the processing stopping completely and a somewhat hard to understand message (especially for people who haven't looked at the Swirlify source). This change will simply put the message into the generated html while allowing processing to continue.
Author
|
Alternatively, the message in stop() could be changed to something a bit more understandable and formatted in a more readable way. |
Member
|
I think this is a good idea, especially as new question types are developed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running lesson_to_html() a unit type (class) that does not exist results in the processing stopping completely and a somewhat hard to understand message (especially for people who haven't looked at the Swirlify source). This change will simply put the message into the generated html while allowing processing to continue.