Handle Info.plist encoded as utf16le
#1498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The March 10th nightly toolchain has the Info.plist file encoded using `utf16le`, which we fail to parse as we expect it to be in `utf8`. Try `utf8` first, and fallback to `utf16le` if we can't parse the file.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
|
Closing in favour of the upstream fix: swiftlang/swift#80775 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The March 10th nightly toolchain has the Info.plist file encoded using
utf16le, which we fail to parse as we expect it to be inutf8. Tryutf8first, and fallback toutf16leif we can't parse the file.