fix: import GPG keys when installing swiftly #453
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisunlimited
requested review from
cmcgee1024,
etcwilde,
justice-adams-apple and
shahmishal
as code owners
Member
|
Thanks @louisunlimited for this fix. Can you merge/rebase it against the latest changes? |
Contributor
Author
|
@cmcgee1024 just did! lmk what else you need :)) |
cmcgee1024
reviewed
Nov 7, 2025
| if let mockedHomeDir = ctx.mockedHomeDir { | ||
| var env = ProcessInfo.processInfo.environment | ||
| env["GNUPGHOME"] = (mockedHomeDir / ".gnupg").string | ||
| try await sys.gpg()._import(key: tmpFile).run(environment: .init(env), quiet: true) |
Member
There was a problem hiding this comment.
issue (blocking): Since updating to swift-subprocess the environment handling is more explicit in that it can be precisely encoded that the environment should be inherited with specific overrides. This line becomes the following:
try await sys.gpg()._import(key: tmpFile).run(environment: .inherit.updating(["GNUPGHOME": (mockedHomeDir / ".gnupg").string]), quiet: true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #443