Fix conformance-related warnings appearing after PR85757 #86183
+9
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conformances `Type: Comparable` and `EnumCase: Equatable` were previously introduced in swiftlang#85757 for implementing AutoDiff closure specialization logic. This patch moves the conformances directly to the SIL module to address warnings mentioned in the comment: swiftlang#85757 (comment)
Contributor
Author
|
@swift-ci Please test |
eeckstein
reviewed
Dec 22, 2025
| hasher.combine(bridged.opaqueValue) | ||
| } | ||
|
|
||
| public static func < (lhs: Type, rhs: Type) -> Bool { |
Contributor
There was a problem hiding this comment.
This is very inefficient. It's better to compare the raw pointers of the bridged type.
For what reason do you need Type to be comparable?
Contributor
Author
There was a problem hiding this comment.
I've introduced that to make test output more predictable when printing an array of types.
I've also just discovered that such a conformance is not required since we have an overload for sort which accepts the comparator function: https://developer.apple.com/documentation/swift/array/sort(by:)
So, I'll use that instead for ADCS tests and just delete this conformance.
Contributor
Author
There was a problem hiding this comment.
@eeckstein See fix in 575333d
Update the PR description correspondingly
kovdan01
changed the title
Type: Comparable and EnumCase: Equatable conformances
Contributor
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conformances
Type: ComparableandEnumCase: Equatablewere previously introduced in #85757 for implementing AutoDiff closure specialization logic. This patch moves the latter directly to the SIL module. The conformanceType: Comparableis deleted, andsort(by:)is used instead ofsortto mimic the same behavior in tests. These changes address warnings mentioned in the comment: #85757 (comment)