SIL: Fix the ownership verifier for guaranteed phi arguments #86176
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The verifier reported a false error in case an unowned (trivial) value was used in an guaranteed phi argument outside the liverange of a borrow scope. For example: ``` %2 = begin_borrow %0 %3 = struct_extract %2 , #KlassAndInt.int // %3 is trivial and can outlive the borrow scope end_borrow %2 %6 = struct $KlassAndInt (%someOtherGuaranteedValue, %3) br bb2(%6) bb2(%8 : @guaranteed $KlassAndInt): // false error reported at the uses of %8 ```
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test windows |
meg-gupta
approved these changes
Dec 22, 2025
Contributor
Author
|
@swift-ci smoke test windows |
Contributor
Author
|
@swift-ci smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verifier reported a false error in case an unowned (trivial) value was used in an guaranteed phi argument outside the liverange of a borrow scope. For example:
Fixes a compiler crash
rdar://167003182