SE-0492: Stabilize @_section/@_used into @section/@used #85074
Merged
+816
−401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the underscored prefixes from the @_section and @_used attributes, making them public as @section and @used respectively. The SymbolLinkageMarkers experimental feature has been removed as these attributes are now part of the standard language. Implemented expression syntactic checking rules per SE-0492. Major parts: - Renamed @_section to @section and @_used to @used - Removed the SymbolLinkageMarkers experimental feature - Added parsing support for the old underscored names with deprecation warnings - Updated all tests and examples to use the new attribute names - Added syntactic validation for @section to align with SE-0492 (reusing the legality checker by @artemcm) - Changed @DebugDescription macro to explicitly use a tuple type instead of type inferring it, to comply with the expression syntax rules - Added a testcase for the various allowed and disallowed syntactic forms, `test/ConstValues/SectionSyntactic.swift`.
kubamracek
requested review from
AnthonyLatsis,
CodaFi,
DougGregor,
bnbarham,
eeckstein,
hamishknight,
hborla,
jckarter,
ktoso,
rintaro,
rjmccall,
slavapestov,
xedin and
xymus
as code owners
|
@swift-ci please test |
DougGregor
reviewed
Oct 23, 2025
lib/Sema/LegalConstExprVerifier.cpp
Outdated
Comment on lines
271
to
272
| if (auto *funcDecl = | ||
| dyn_cast<FuncDecl>(memberRef->getMember().getDecl())) { |
There was a problem hiding this comment.
This looks like it will let through references to instance methods, which can't be expressed as constants. Something like 17.negate, perhaps, would slip through the check?
|
+@kastiglione for the |
…yntactic checking
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
DougGregor
approved these changes
Oct 24, 2025
kastiglione
approved these changes
Oct 24, 2025
| /// into some other syntax, specifically as a tuple. | ||
| fileprivate mutating func appendInterpolation(swiftLiteral bytes: [UInt8]) { | ||
| let literalBytes = bytes.map({ "\($0) as UInt8" }).joined(separator: ", ") | ||
| let literalBytes = bytes.map({ "\($0)" }).joined(separator: ", ") |
There was a problem hiding this comment.
is it idiomatic to use interpolation for the case where a single variable is being converted to a string ("\($0)")?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the underscored prefixes from the
@_sectionand@_usedattributes, making them public as@sectionand@usedrespectively. The SymbolLinkageMarkers experimental feature has been removed as these attributes are now part of the standard language. Implemented expression syntactic checking rules per SE-0492.Major parts:
@_sectionto@sectionand@_usedto@used@sectionto align with SE-0492 (reusing the legality checker by @artemcm)@DebugDescriptionmacro to explicitly use a tuple type instead of type inferring it, to comply with the expression syntax rulestest/ConstValues/SectionSyntactic.swift.Note that there are is no code change for actual constant folding. This is already implemented in MandatoryPerformanceOptimizations based on
.mustBeInitializedStaticallyproperty being true for any@_section/@sectionannotated global.TODO:
@const"test/ConstValues/SectionSyntactic.swift@section-annotated globals in script mode / top-level mode