Enable more tests for Embedded Wasm #82399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test linux |
1 similar comment
|
@swift-ci smoke test linux |
MaxDesiatov
requested review from
kubamracek,
eeckstein,
bnbarham,
rauhul and
kateinoigakukun
MaxDesiatov
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
MaxDesiatov
added
test suite
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci smoke test |
kubamracek
reviewed
Jun 24, 2025
kubamracek
reviewed
Jun 24, 2025
There's a predefined list of supported platforms that WASI should be added now that it has an official Embedded Swift SDK.
The overall change should be only localized to executable tests for now.
MaxDesiatov
force-pushed
the
maxd/embedded-wasm-tests
branch
from
50f4eaf to
2c391e4
Compare
|
@swift-ci smoke test |
kubamracek
reviewed
Jun 27, 2025
| @@ -1,6 +1,6 @@ | |||
| // RUN: %empty-directory(%t) | |||
| // RUN: %target-swift-frontend -enable-experimental-feature Embedded -parse-as-library %s -c -o %t/a.o | |||
| // RUN: %target-clang %t/a.o -o %t/a.out -L%swift_obj_root/lib/swift/embedded/%target-cpu-apple-macos -lswift_Concurrency -lswift_ConcurrencyDefaultExecutor -dead_strip | |||
| // RUN: %target-clang %target-clang-resource-dir-opt %t/a.o -o %t/a.out -L%swift_obj_root/lib/swift/embedded/%target-triple -lc++ -lswift_Concurrency -lswift_ConcurrencyDefaultExecutor -dead_strip | |||
There was a problem hiding this comment.
Does the change from %target-cpu-apple-macos to %target-triple still actually work and pass in CI? If yes, then great, but I think I remember that I had to use the former because for macOS, %target-triple includes the version number and that's not in the directory name...
kubamracek
approved these changes
Jun 27, 2025
|
LGTM, and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests still require a manual
lit.pyinvocation for Wasm, which will be added as a separate CMake target in a future PR.