Skip to content

move NodePrinter declarations to a header #82303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

charles-zablit
Copy link
Contributor

This patch moves the declaration of NodePrinter to the Demangle.h header. It does not edit the definitions of the class and its attributes.

This patch precedes #82298 which will add new methods to NodePrinter.

@charles-zablit charles-zablit self-assigned this Jun 17, 2025
@charles-zablit charles-zablit requested a review from a team as a code owner June 17, 2025 16:31
@charles-zablit charles-zablit added the demangling Area → compiler: The `libswiftDemangling` library label Jun 17, 2025
@charles-zablit
Copy link
Contributor Author

@swift-ci please test

@adrian-prantl
Copy link
Contributor

See #82298 can you rebase this PR on main?

@charles-zablit
Copy link
Contributor Author

See #82298 can you rebase this PR on main?

Sure, closing this PR and reopened #82335 because rebasing might add too many people as reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demangling Area → compiler: The `libswiftDemangling` library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants