[6.2] Fix an inliner crash when inlining begin_apply with scoped lifetime dependence #82224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
tbkka
approved these changes
Jun 12, 2025
meg-gupta
force-pushed
the
fixinlinercrashcp
branch
from
d934758 to
fe35118
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
fixinlinercrashcp
branch
from
fe35118 to
d5b82a3
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
LifetimeDependenceInsertioninsertsmark_dependenceon the token result of abegin_applywhen it yields a lifetime dependent value. When such abegin_applygets inlined, the inliner can crash because of the remaining uses of the token result.Fix this by inserting
mark_dependenceon parameter operands that are lifetime dependence sources and deleting themark_dependenceon the token result in the inliner.Scope: Affects lifetime dependencies on coroutines. No stdlib coroutines have lifetime dependencies.
Risk: Low
Issue: rdar://151568816
Reviewer: @atrick
Main PR: #82033
Testing: Added unit tests, CI testing