[6.2][Concurrency] NonisolatedNonsendingByDefault: Migration applies only to the current module declarations #82219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the current module declarations Prevent migration from handling declarations that come from a module different from the current one, this is primarily a problem for swiftinterfaces that can get rebuilt when the module is imported by a model that has migration mode enabled. Resolves: rdar://152687353 (cherry picked from commit bcd6caa)
…ft` test into `migration_mode.swift` (cherry picked from commit 1457aec)
…check higher This is a follow-up to swiftlang#82173 which moves the check higher to make it an early exist. (cherry picked from commit f0502c2)
bnbarham
approved these changes
Jun 12, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #82173 and #82218
Explanation:
Prevent migration from handling declarations that come from a
module different from the current one, this is primarily a
problem for swiftinterfaces that can get rebuilt when the module
is imported by a model that has migration mode enabled.
Resolves: rdar://152687353
Main Branch PRs: [Concurrency] NonisolatedNonsendingByDefault: Migration applies only to the current module declarations #82173 and [Concurrency] NonisolatedNonsendingByDefault/NFC: Move 'same module' … #82218
Risk: Very Low. The change applies to migration mode of the feature that is not enabled by default.
Reviewed By: @AnthonyLatsis
Testing: Added new test-cases to the test suite.