Skip to content

[Concurrency] NonisolatedNonsendingByDefault/NFC: Move 'same module' … #82218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

[Concurrency] NonisolatedNonsendingByDefault/NFC: Move 'same module' … #82218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/Sema/NonisolatedNonsendingByDefaultMigration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ void NonisolatedNonsendingByDefaultMigrationTarget::diagnose() const {
return;
}

// Only diagnose declarations from the current module.
if (decl->getModuleContext() != ctx.MainModule) {
return;
}

// If the attribute cannot appear on this kind of declaration, we can't
// diagnose it.
if (!DeclAttribute::canAttributeAppearOnDecl(DeclAttrKind::Concurrent,
Expand Down Expand Up @@ -153,10 +158,6 @@ void NonisolatedNonsendingByDefaultMigrationTarget::diagnose() const {

const auto featureName = feature.getName();
if (decl) {
// Only diagnose declarations from the current module.
if (decl->getModuleContext() != ctx.MainModule)
return;

// Diagnose the function, but slap the attribute on the storage declaration
// instead if the function is an accessor.
auto *functionDecl = dyn_cast<AbstractFunctionDecl>(decl);
Expand Down