[6.2][cxx-interop] Fix crash in ASTMangler triggered by UsingShadowDecls #82175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: We did not handle this declaration kind. This PR makes sure we mangle it the same way we do for the target declaration. Issue: rdar://152841420 Risk: Low, the fix is small, localized, and straightforward. Testing: Regression test added. Original PR: #82144 Reviewer: @egorzhdan @hnrklssn @j-hui
Xazax-hun
added
c++ interop
Contributor
Author
|
@swift-ci please test |
j-hui
approved these changes
Jun 11, 2025
hnrklssn
approved these changes
Jun 11, 2025
egorzhdan
approved these changes
Jun 11, 2025
DougGregor
approved these changes
Jun 23, 2025
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
Yeah, this looks like the right solution. Using declarations shouldn't affect the mangling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We did not handle this declaration kind. This PR makes sure we mangle it the same way we do for the target declaration.
Issue: rdar://152841420
Risk: Low, the fix is small, localized, and straightforward.
Testing: Regression test added.
Original PR: #82144
Reviewer: @egorzhdan @hnrklssn @j-hui