{AST,Basic}Bridging: Use <swift/bridging> and try directly bridging one of our enums
#82165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
DougGregor,
bnbarham,
CodaFi,
hamishknight,
rintaro,
hborla,
slavapestov,
xedin and
jckarter
as code owners
|
@swift-ci please smoke test |
|
Let’s see if I’m being too ambitious. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test Windows |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
…ing our own macros
|
@swift-ci please smoke test |
hamishknight
approved these changes
Jun 16, 2025
Comment on lines
+123
to
+125
| SWIFT_COMPUTED_PROPERTY | ||
| const void *_Nullable getRaw() const { return Raw; } |
include/swift/Basic/BasicBridging.h
Outdated
Comment on lines
250
to
251
| const uint8_t *_Nullable getData() const { | ||
| return (const uint8_t *)(Data ? Data : ""); |
There was a problem hiding this comment.
Huh, seems like this isn't actually nullable?
There was a problem hiding this comment.
Oh, the Data itself is nonnull. Perhaps we don’t need this ternary at all.
There was a problem hiding this comment.
Hm, the constructor sets Data to nullptr. I thought _Nonnull was supposed to prevent this.
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<swift/bridging>.swift::DiagnosticKindinstead of having an intermediateBridgedDiagnosticSeverityenum.