-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[6.2] Update spelling for representing lifetime dependencies to @_lifetime #82146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci test |
ac5367b
to
e43fb42
Compare
@swift-ci test |
@swift-ci test |
tbkka
approved these changes
Jun 11, 2025
@swift-ci test |
c22d664
to
cd07359
Compare
@swift-ci test |
@swift-ci test |
@swift-ci test |
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: LifetimeDependence is a supported experimental feature for which we have to maintain source compatibility. During language evolution if we decide to update its semantics or syntax under
@lifetime
attribute, it can introduce significant confusion and maintenance problems to both early adopters and compiler developers.To mitigate this, this PR introduces an underscore, effectively making the annotation
@_lifetime
, to provide a clear distinction and avoid potential conflicts during future development. Standard library will continue to use@lifetime
in the near term.@_lifetime
is implemented as a suppressible language feature and@lifetime
is printed in the suppressed path since the oldest compilers we have to support with a new sdk have support for@lifetime
. This will ensure when the standard library migrates to@_lifetime
we will continue to support older compilers.Issue: rdar://151901744
Scope: Affects early adopters of lifetime dependencies
Risk: Medium. Along with the source changes being large, this change can cause a warning with @Lifetime uses outside the stdlib.
Main PR: #82067
Reviewers: @atrick @tshortli
Testing: swift CI testing.