Skip to content

[6.2, stdlib] make _overrideLifetime() functions public #81225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Apr 30, 2025

This is a cherry-pick of #81224, reviewed by @meg-gupta and @atrick.

These functions are discussed in the lifetime annotations pitch: swiftlang/swift-evolution#2750
They are necessary to implement functions returning non-escapable values, such as Data.bytes.

Addresses rdar://150400414

@glessard glessard added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Apr 30, 2025
@glessard glessard requested review from eeckstein and a team as code owners April 30, 2025 23:37
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard
Copy link
Contributor Author

glessard commented May 6, 2025

@swift-ci please test

@glessard
Copy link
Contributor Author

glessard commented May 7, 2025

@swift-ci please test macOS platform

@glessard glessard requested a review from stephentyrone May 7, 2025 16:27
@glessard glessard changed the base branch from main to release/6.2 May 8, 2025 00:10
@glessard glessard requested a review from a team as a code owner May 8, 2025 00:10
glessard added 4 commits May 7, 2025 17:13
These are discussed in the lifetime annotations pitch: swiftlang/swift-evolution#2750

Addresses rdar://150400414
These TODOs aren’t particularly actionable. What we really want is a way to define `_overrideLifetime()` in a not-unsafe way, and that will probably be a `Builtin` operation.
@glessard glessard force-pushed the override-lifetime-publicly-6.2 branch from 17428a3 to ca8fc0e Compare May 8, 2025 00:14
@glessard
Copy link
Contributor Author

glessard commented May 8, 2025

@swift-ci please test

@glessard glessard merged commit 8d86093 into swiftlang:release/6.2 May 8, 2025
5 checks passed
@glessard glessard deleted the override-lifetime-publicly-6.2 branch May 8, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants