[rbi] Simplify some logic that got confused so that passing an actor isolated value to a callee that is isolated ot the same actor is not considered a send. #80911
+46
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isolated value to a callee that is isolated ot the same actor is not considered a send. The logic here got confused over time. This simplifies the logic and ensures that we do not send a value if it is in the same isolation domain as the callee. The one interesting side effect of this is that in a few tests, due to the logic being confused, we were emitting use-after-send errors for global actor isolated values that were passed to a function that was global actor isolated to the same actor and then used later locally. The error was sending 'X'-isolated a to 'X'-isolated function causes race against nonisolated local uses. In truth, this error is misleading and the only error that we should be emitting in such a case is the error about moving an isolated value into a non-isolated context (which we already emit). rdar://132932382
|
@swift-ci smoke test |
|
@swift-ci smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic here got confused over time. This simplifies the logic and ensures that we do not send a value if it is in the same isolation domain as the callee.
The one interesting side effect of this is that in a few tests, due to the logic being confused, we were emitting use-after-send errors for global actor isolated values that were passed to a function that was global actor isolated to the same actor and then used later locally. The error was sending 'X'-isolated a to 'X'-isolated function causes race against nonisolated local uses. In truth, this error is misleading and the only error that we should be emitting in such a case is the error about moving an isolated value into a non-isolated context (which we already emit).
rdar://132932382