utils: extract Build-SDK helper
#80157
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
CC: @jeffdav |
|
I was excited until I read build.ps1.. nothing for me on Ubuntu |
Shouldn't be too terrible to port build.ps1 to run on Ubuntu. It will require just going through and adjusting the host expectation of Windows. |
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
Why are you maintaining a windows only file? I figured this script‘s features would be more or less the same as build-script. |
| Android { | ||
| $SDKSettings.SupportedTargets.Android.LLVMTargetVendor = "unknown" | ||
| $SDKSettings.SupportedTargets.Android.LLVMTargetSys = "linux" | ||
| $SDKSettings.SupportedTargets.Android.LLVMTargetTripleEnvironment = "android${AndroidAPILevel}" |
There was a problem hiding this comment.
FWIW, SwiftBuild has android and windows as lowercase under "SupportedTargets".
Environment also should be androideabi for armv7, but we have no way to vary that per architecture right now.
There was a problem hiding this comment.
Interesting. I thought it was androideabi as well. However, when we recently updated the install rules to use the output of swiftc -print-target-info, we end up with armv7-unknown-linux-android. I'm happy to change this to androideabi for armv7 though.
There was a problem hiding this comment.
I'm happy to change this to androideabi for armv7 though.
You can't at present, because the current schema only allows specifying the triple components per logical platform not per architecture. We'd need to extend the SDKSettings schema (the "authoritative" implementation lives in Swift Build) to allow that.
build-script is not portable; it does not support the necessary setup that Windows requires (integration with VS), support for cross-compilation, doesn't do the optimized build tricks that we do for minimizing the build, nor does it handle paths properly (path limits are a serious concern on Windows). |
This creates a helper for building the SDK for a given OS/Architecture. The building of the SDK should be uniform and this ensures that we can maintain that uniformity. This also highlights any structural changes that are being adjusted manually. The desire is to bring this to zero by gaining control over the install rules.
|
@swift-ci please test Windows platform |
|
Please test with following PRs: @swift-ci please test Windows platform |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
|
According to #80356 (comment), this might fix #80356. Is there an ETA on when this will land? |
|
@bkhouri this needs @shahmishal or @etcwilde to approve swiftlang/swift-installer-scripts#407, but this is ready to go otherwise. |
This creates a helper for building the SDK for a given OS/Architecture. The building of the SDK should be uniform and this ensures that we can maintain that uniformity.
This also highlights any structural changes that are being adjusted manually. The desire is to bring this to zero by gaining control over the install rules.