[stdlib] Adopt typed throws in some Dictionary APIs and some Sequence APIs #77957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test |
|
Awesome! Given this pending PR: #79937 should we be using |
|
Yeah we should use those, but if this lands first then I'll make a followup. If that lands first I'll edit this PR. |
|
@swift-ci please test |
Azoy
requested review from
bnbarham,
hamishknight,
rintaro,
hborla,
xedin and
eeckstein
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another round of typed throws adoption in the stdlib. This time I've opted for
Dictionary.compactMapValues,Dictionary.mapValues,Sequence.filter,Sequence.forEach, and both variants ofSequence.reduce. I chose these few particularly because of folks reaching for them and surprised they weren't already typed (more specifically,mapValuesandfilter, but the rest were close enough and easy enough to do as well.Resolves: rdar://140307946