Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote attachments to API #973

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Promote attachments to API #973

wants to merge 3 commits into from

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Feb 24, 2025 •
edited
Loading

This PR promotes attachments to API, pending approval of the proposal at swiftlang/swift-evolution#2719.

View the full proposal here.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added enhancement New feature or request public-api Affects public API api-proposal API proposal PRs (documentation only) attachments/activities 🖇️ Work related to attachments and/or activities labels Feb 24, 2025
@grynspan grynspan added this to the Swift 6.x milestone Feb 24, 2025
@grynspan grynspan self-assigned this Feb 24, 2025
@grynspan grynspan removed the api-proposal API proposal PRs (documentation only) label Mar 3, 2025
@grynspan grynspan changed the title [SWT-NNNN] Attachments Promote attachments to API Mar 3, 2025
@grynspan grynspan force-pushed the jgrynspan/attachments-proposal branch from bd29a04 to a23cb26 Compare March 20, 2025 22:23
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan added the api-proposal API proposal PRs (documentation only) label Mar 20, 2025
grynspan added 3 commits March 25, 2025 11:02
@grynspan
[SWT-NNNN] Attachments
86c0a7d 
Test authors frequently need to include out-of-band data with tests that can be
used to diagnose issues when a test fails. This proposal introduces a new API
called "attachments" (analogous to the same-named feature in XCTest) as well as
the infrastructure necessary to create new attachments and handle them in tools
like VS Code.

Read the full proposal [here]().
@grynspan
Move proposal to Swift Evolution
376e4d0
@grynspan
Remove some more SPI attributes
82cbdc4
@grynspan grynspan force-pushed the jgrynspan/attachments-proposal branch from a23cb26 to 82cbdc4 Compare March 25, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
api-proposal API proposal PRs (documentation only) attachments/activities 🖇️ Work related to attachments and/or activities enhancement New feature or request public-api Affects public API
Projects
None yet
Milestone
Swift 6.2
Development

Successfully merging this pull request may close these issues.
1 participant
@grynspan