Promote attachments to API #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
force-pushed
the
jgrynspan/attachments-proposal
branch
from
bd29a04 to
a23cb26
Compare
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/attachments-proposal
branch
from
a23cb26 to
82cbdc4
Compare
|
@swift-ci test |
Test authors frequently need to include out-of-band data with tests that can be used to diagnose issues when a test fails. This proposal introduces a new API called "attachments" (analogous to the same-named feature in XCTest) as well as the infrastructure necessary to create new attachments and handle them in tools like VS Code. Read the full proposal [here]().
grynspan
force-pushed
the
jgrynspan/attachments-proposal
branch
from
82cbdc4 to
6bb6c5c
Compare
|
@younata Mind giving this a quick look? |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
younata
approved these changes
Apr 9, 2025
|
@swift-ci test |
stmontgomery
approved these changes
Apr 10, 2025
|
macOS build is hanging on infra, gonna merge before it's done, #yolo as they say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR promotes attachments to API and makes the appropriate changes to match what was approved in the review of ST-0009.
Checklist: