Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Remove legacy test content discovery. #1013

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Remove legacy test content discovery. #1013

wants to merge 1 commit into from

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Mar 11, 2025 •
edited
Loading

This PR removes the legacy test content discovery mechanism that is based on finding protocol conformances in the type metadata section emitted by the Swift compiler.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added enhancement New feature or request tools integration Integration of swift-testing into tools/IDEs less-c++ Work to reduce the size of our C++ codebase and/or dependencies labels Mar 11, 2025
@grynspan grynspan self-assigned this Mar 11, 2025
@grynspan grynspan added the embedded-swift Embedded Swift issues label Mar 11, 2025
@grynspan grynspan force-pushed the jgrynspan/move-static-section-bounds-to-swift branch 3 times, most recently from 8e967cf to e107fa4 Compare March 12, 2025 12:36
@grynspan grynspan force-pushed the jgrynspan/remove-legacy-test-discovery branch from b6c0f25 to 678ea6d Compare March 12, 2025 12:43
@grynspan grynspan added the discovery 🔎 test content discovery label Mar 12, 2025
@grynspan grynspan force-pushed the jgrynspan/move-static-section-bounds-to-swift branch from e107fa4 to 7a4f5dd Compare March 17, 2025 14:12
Base automatically changed from jgrynspan/move-static-section-bounds-to-swift to main March 19, 2025 19:06
@grynspan grynspan force-pushed the jgrynspan/remove-legacy-test-discovery branch 2 times, most recently from e77147e to 52d997b Compare March 19, 2025 19:28
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Remove legacy test content discovery.
9152e84 
This PR removes the legacy test content discovery mechanism that is based on
finding protocol conformances in the type metadata section emitted by the Swift
compiler.
@grynspan grynspan force-pushed the jgrynspan/remove-legacy-test-discovery branch from 52d997b to 9152e84 Compare March 24, 2025 15:55
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan added this to the Swift 6.x milestone Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery will be requested when the pull request is marked ready for review stmontgomery is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom will be requested when the pull request is marked ready for review briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski will be requested when the pull request is marked ready for review SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff will be requested when the pull request is marked ready for review suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
discovery 🔎 test content discovery embedded-swift Embedded Swift issues enhancement New feature or request less-c++ Work to reduce the size of our C++ codebase and/or dependencies tools integration Integration of swift-testing into tools/IDEs
Projects
None yet
Milestone
Swift 6.x
Development

Successfully merging this pull request may close these issues.
1 participant
@grynspan