FixItApplier: Misc improvements #3121
Conversation
AnthonyLatsis
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
|
|
||
| // Drop any subsequent edits that conflict with one we just applied, and | ||
| // adjust the range of the rest. | ||
| while true { |
There was a problem hiding this comment.
Am I missing something or could this be a for loop like
for adjustmentEditIndex in editIndex..<edits.endIndexThere was a problem hiding this comment.
for adjustmentEditIndex in (editIndex + 1)..<edits.endIndex, yeah. Sounds good.
There was a problem hiding this comment.
I just remembered. I did this because it felt less safe to have 2 index variables in scope in the inner loop.
There was a problem hiding this comment.
I crammed the increment into the while condition but I don’t think you’re going to like this 😅
AnthonyLatsis
force-pushed
the
jepa2
branch
2 times, most recently
from
6d1fd86 to
bc79daf
Compare
There was a problem hiding this comment.
LGTM, could you add a short RFC post for the new API as described in https://github.com/swiftlang/swift-syntax/blob/main/Contributor%20Documentation/RFC%20Process.md?
|
Thank you, loved the feedback!
For the new parameter you mean? Even though |
|
Sorry, didn’t realize that |
|
Ah, to be fair, I did add a |
|
@swift-ci please test |
|
@swift-ci please test Windows |
swift package migrate, this will enable us to prevent repeated fix-it application in various scenarios where multiple elements in a protocol composition type are diagnosed with the same insertion fix-it.