Skip to content

[6.2] Avoid eating """ as closing " delimiter #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

[6.2] Avoid eating """ as closing " delimiter #3119

merged 1 commit into from
Jul 1, 2025

Conversation

hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Jul 1, 2025 •
edited
Loading

6.2 cherry-pick of #3116

  • Explanation: Fixes a crash that could occur when a single-line string literal is terminated with """
  • Scope: Affects invalid string literals
  • Issue: rdar://154172057, Parser crashes on invalid multi-line literal #3113
  • Risk: Low, only affects invalid syntax
  • Testing: Added tests to test suite
  • Reviewer: Rintaro Ishizaki

@hamishknight
Avoid eating """ as closing " delimiter
ec39346 
Previously we could incorrectly try to eat `"""` as the closing
delimiter for e.g `"a"""`. Make sure we only eat a single `"`.
@hamishknight hamishknight requested a review from bnbarham July 1, 2025 10:43
@hamishknight hamishknight requested a review from a team as a code owner July 1, 2025 10:43
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit ab38925 into swiftlang:release/6.2 Jul 1, 2025
51 checks passed
@hamishknight hamishknight deleted the air-quotes-6.2 branch July 1, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishknight @bnbarham