Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1] Add dependency to 601 marker module #3036

Merged
merged 2 commits into from
Apr 2, 2025
Merged

[6.1] Add dependency to 601 marker module #3036

merged 2 commits into from
Apr 2, 2025

Conversation

mbrandonw
Copy link
Contributor

@mbrandonw mbrandonw commented Apr 1, 2025 •
edited by bnbarham
Loading

  • Explanation: 601.0.0 is missing a dependency from SwiftSyntax to the 601 marker module, causing canImport checks on it to fail. This prevents adoption of 601 for macros following the versioning guide.
  • Scope: Primarily macros
  • Issue: n/a
  • Original PR: Specify SwiftSyntax601 in more places. #3034
  • Risk: None, just adds a dependency to an otherwise empty module
  • Testing: Checked canImport now returns true for 601
  • Reviewer: @bnbarham

@mbrandonw mbrandonw mentioned this pull request Apr 1, 2025
Merged
@bnbarham bnbarham changed the title Fix 601 version module release 6.1 [6.1] Add dependency to 601 marker module Apr 1, 2025
@bnbarham
Copy link
Contributor

bnbarham commented Apr 1, 2025

@swift-ci please test

@bnbarham
Copy link
Contributor

bnbarham commented Apr 2, 2025

swiftlang/swift#80453

@swift-ci please test macOS platform

@liamnichols liamnichols mentioned this pull request Apr 2, 2025
Merged
@bnbarham bnbarham merged commit f99ae8a into swiftlang:release/6.1 Apr 2, 2025
3 checks passed
@bnbarham
Copy link
Contributor

bnbarham commented Apr 2, 2025

I've just tagged 601.0.1. Thanks @mbrandonw!

@mbrandonw
Copy link
Contributor Author

@bnbarham Thanks!

@ssarad ssarad mentioned this pull request Apr 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

@airspeedswift airspeedswift airspeedswift approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbrandonw @bnbarham @keith @airspeedswift