Fix concurrency warnings in AsyncProcess #9430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashes the warnings in AsyncProcess by adjusting required callbacks to be `@Sendable`, marking lock protected state as `nonisolated(unsafe)` and using a `ThreadSafeBox` to capture the process result.
plemarquand
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test Linux |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test macos |
| package typealias LoggingHandler = @Sendable (String) -> Void | ||
|
|
||
| private static var _loggingHandler: LoggingHandler? | ||
| nonisolated(unsafe) private static var _loggingHandler: LoggingHandler? |
Contributor
There was a problem hiding this comment.
Instead of nonisolated(unsafe) can you use ThreadSafeBox?
Contributor
Author
There was a problem hiding this comment.
Good call. I've also updated validatedExecutablesMap to use ThreadSafeKeyValueStore.
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
3 similar comments
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashes the warnings in AsyncProcess by adjusting required callbacks to be
@Sendable, marking lock protected state asnonisolated(unsafe)and using aThreadSafeBoxto capture the process result. Fixes up warnings in AsyncProcessTests as well.