Include out-of-target sources #8900
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkiSakurai
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for out-of-target declared sources and headers in TargetSourcesBuilder for tools version vNext
Motivation:
Since out-of-target resources are already supported, this change extends similar support to out-of-target declared sources and headers, enabling consistent handling of external source files in package loading for tools versions >= vNext.
Modifications:
Updated TargetSourcesBuilder to process declaredSources, categorizing unhandled sources as headers or additional sources based on file extensions. Added logic to integrate these sources and headers for tools versions >= vNext.
Result:
TargetSourcesBuilder now supports out-of-target declared sources and headers, allowing seamless inclusion of external source files in package loading for tools versions >= vNext.