ProcessID enhacement #8618
Open
ProcessID enhacement #8618
+289
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbute
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
Still need to add tests + rename to something clearer. if you have any suggestions on naming, please let me know :) |
|
@swift-ci please test |
|
@swift-ci please test |
johnbute
force-pushed
the
feature/pid-enhancement
branch
from
0e93697 to
1963d73
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
bripeticca
reviewed
May 8, 2025
johnbute
force-pushed
the
feature/pid-enhancement
branch
from
10b1dd4 to
670f56a
Compare
|
@swift-ci please test |
cmcgee1024
reviewed
May 12, 2025
cmcgee1024
reviewed
May 12, 2025
cmcgee1024
reviewed
May 13, 2025
bkhouri
reviewed
May 13, 2025
johnbute
force-pushed
the
feature/pid-enhancement
branch
from
670f56a to
9972cd3
Compare
johnbute
force-pushed
the
feature/pid-enhancement
branch
from
9972cd3 to
31cb5e3
Compare
|
@swift-ci please test |
|
@swift-ci test windows |
bripeticca
reviewed
May 27, 2025
Comment on lines
+1
to
+6
| // | ||
| // PIDTests.swift | ||
| // SwiftPM | ||
| // | ||
| // Created by John Bute on 2025-05-14. | ||
| // |
There was a problem hiding this comment.
todo: marking this for visibility! :) for new files, this is the suggested header -->
Suggested change
| // | |
| // PIDTests.swift | |
| // SwiftPM | |
| // | |
| // Created by John Bute on 2025-05-14. | |
| // | |
| //===----------------------------------------------------------------------===// | |
| // | |
| // This source file is part of the Swift.org open source project | |
| // | |
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | |
| // Licensed under Apache License v2.0 with Runtime Library Exception | |
| // | |
| // See https://swift.org/LICENSE.txt for license information | |
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | |
| // | |
| //===----------------------------------------------------------------------===// |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays the PID of the SwiftPM instance currently holding the lock
Motivation:
Fixes #8528
Modifications:
Added a new abstraction for handling a .pid file which contains the pID of the currently running SwiftPM instance.
introduced the pidfileManipulator protocol and its implementation in pidFile struct to handle reading, writing, and deleting the PID file
Updated SwiftCommandState to use the pidFileManipulator to handle the pid file when attempting to acquire or release the lock.
Result:
Enhancement of knowing which processes are currently holding the lock + automatic cleanup