Fix bootstrapping on OpenBSD #8451
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3405691582
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test. |
Only minor changes are required, however because of #80059 and swiftpm's use of Concurrency, this only builds on the configuration where BTCFI is disabled. We can revisit some of that perhaps later; what matters is that swiftpm finally builds.
|
@swift-ci please test. |
MaxDesiatov
changed the title
|
@swift-ci please test Windows platform |
|
@swift-ci test windows |
|
@swift-ci test self hosted windows |
|
@swift-ci please test self hosted windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Ensure swiftpm bootstraps successfully to fully build an OpenBSD toolchain.
Modifications:
Add the nobtcfi linker flag to the bootstrap script for OpenBSD. This is unconditional for now since swiftpm uses Concurrency liberally and this triggers #80059, so swiftpm only builds on the configuration where BTCFI is disabled. We can revisit some of that perhaps later.
Ensure SPMSQLite3 builds with the correct link library search path flag in CMakeLists.txt.
Update Package.swift conditionals for SPMSQLite3.
Result:
swiftpm successfully builds and bootstraps on OpenBSD.