Skip to content

[6.2] include <stdnoreturn.h> last #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/6.2
Choose a base branch
from

Conversation

Steelskin
Copy link
Contributor

@Steelskin Steelskin commented Jun 5, 2025

  • Explanation:
    Starting with the Windows SDK 10.0.26100.3916, inclusion of <stdnoreturn.h> clashes with some of the definitions in other ucrt headers. Move <stdnoreturn.h> to be last to work around this issue.
  • Scope:
    Limited to the include order in one file.
  • Issues:
    N/A
  • Original PRs:
    Include <stdnoreturn.h> last #1330
  • Risk:
    <stdnoreturn.h> is not a requirement for any of the other headers in this file, so the risk is minimal
  • Testing:
    Local build with a 10.0.26100.3916 Windows SDK
  • Reviewers:
    @compnerd

Starting with the Windows SDK 10.0.26100.3916, inclusion of
`<stdnoreturn.h>` clashes with some of the definitions in other ucrt
headers. Move `<stdnoreturn.h>` to be last to work around this issue.
@compnerd
Copy link
Member

compnerd commented Jun 5, 2025

@swift-ci please smoke test

@compnerd
Copy link
Member

compnerd commented Jun 5, 2025

@swift-ci please test

@compnerd compnerd requested a review from parkera June 5, 2025 17:25
@Steelskin Steelskin changed the title [6.2] include <stdnoreturn> last [6.2] include <stdnoreturn.h> last Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants