[Incremental Builds] Separately check whether we can skip 'emit-module' on an incremental module-only build #1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
artemcm
force-pushed
the
IncrementalEmitModuleOnly
branch
from
0c71e8d to
1909528
Compare
|
@swift-ci test |
|
@swift-ci test Windows platform |
1 similar comment
|
@swift-ci test Windows platform |
artemcm
force-pushed
the
IncrementalEmitModuleOnly
branch
from
1909528 to
6d04f92
Compare
|
@swift-ci test |
artemcm
force-pushed
the
IncrementalEmitModuleOnly
branch
from
6d04f92 to
ae2a999
Compare
|
@swift-ci test |
Sources/SwiftDriver/IncrementalCompilation/FirstWaveComputer.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/IncrementalCompilation/FirstWaveComputer.swift
Outdated
Show resolved
Hide resolved
…e' on an incremental module-only build Resolves rdar://151626629
artemcm
force-pushed
the
IncrementalEmitModuleOnly
branch
from
ae2a999 to
82a2ef6
Compare
|
@swift-ci test |
|
@swift-ci test Windows platform |
owenv
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the incremental machinery is in a state that no source files require to be re-compiled, it may also determine that all the corresponding before-compile tasks may also be skipped, such as
emit-module. On emit-module-only builds however, this logic is invalid because the individual file compilation is always skipped by not being included in the build plan.This PR adds logic for specifically cases where no source files must be compiled on an incremental build because the build plan does not require source compilation, adding logic to ensure that the
emit-moduletasks are skipped only when all of the.swiftinputs to the tasks are older than all of the existing outputs of such tasks.Resolves rdar://151626629