Skip to content

Revert "Pin Windows nightly images to 3/10 snapshot" #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Jun 10, 2025

This reverts commit 0e6e138 (#453).

Fixes: swiftlang/swift#80356

@bkhouri bkhouri requested a review from shahmishal as a code owner June 10, 2025 16:57
@bkhouri bkhouri marked this pull request as draft June 10, 2025 16:59
@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 10, 2025

swiftlang/swift#80356 is not actually fixed. so keeping as draft until then.

@bkhouri
Copy link
Contributor Author

bkhouri commented Jun 12, 2025

Tested the Dockerfile changes on a Windows machine and they are working again.

They were build as follows:

docker build -f <docker_file> . -t <somename>
docker run -it --rm <somename> powershell.exe

And the following was run in the container

PS C:\> mkdir sources

PS C:\> cd sources

PS C:\sources> swift --version
Swift version 6.2-dev (LLVM 3c4a54b02dd62b7, Swift a40a7be6945a895)
Target: x86_64-unknown-windows-msvc
Build config: +assertions
PS C:\sources> swift package init --type library
Creating library package: sources
Creating Package.swift
Creating .gitignore
Creating Sources
Creating Sources\sources\sources.swift
Creating Tests/
Creating Tests\sourcesTests/
Creating Tests\sourcesTests\sourcesTests.swift

PS C:\sources> swift test
Building for debugging...
[26/26] Linking sourcesPackageTests.xctest
Build complete! (51.43s)
Test Suite 'All tests' started at 2025-06-12 10:59:20.252
Test Suite 'debug.xctest' started at 2025-06-12 10:59:20.270
Test Suite 'debug.xctest' passed at 2025-06-12 10:59:20.270
         Executed 0 tests, with 0 failures (0 unexpected) in 0.0 (0.0) seconds
Test Suite 'All tests' passed at 2025-06-12 10:59:20.270
         Executed 0 tests, with 0 failures (0 unexpected) in 0.0 (0.0) seconds
◊ Test run started.
→ Testing Library Version: 6.3-dev (25b61ef4667a6d1)
→ Target Platform: x86_64-unknown-windows-msvc
◊ Test example() started.
√ Test example() passed after 0.001 seconds.
√ Test run with 1 test in 0 suites passed after 0.001 seconds.

@shahmishal shahmishal merged commit 80fd5f8 into swiftlang:main Jun 12, 2025
1 check passed
@bkhouri bkhouri deleted the t/main/gh80356_remove_pinned_swift_version branch June 12, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] regression: swift --version, swift build does not output anything to console and returns immediately
2 participants