Install binaries under $SWIFT_PREFIX/usr/bin instead of /usr/bin
#455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkebo
force-pushed
the
install-binaries-under-swift-prefix
branch
from
984462a to
fd82e29
Compare
kkebo
force-pushed
the
install-binaries-under-swift-prefix
branch
from
0628abe to
6902af9
Compare
This prevents some binaries from being unintentionally overwritten by the system package manager. Symbolic links are also placed in the old directory (`/usr/bin`) for compatibility.
…/bin` This prevents some binaries from being unintentionally overwritten by the system package manager. Symbolic links are also placed in the old directory (`/usr/bin`) for compatibility.
kkebo
force-pushed
the
install-binaries-under-swift-prefix
branch
from
6902af9 to
0225a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fixes #383
This prevents some binaries from being unintentionally overwritten by the system package manager.
Changes
I added the following changes to 6.0 Dockerfiles, 6.1 Dockerfiles, nightly-6.1 Dockerfiles, and nightly-main Dockerfiles.
$SWIFT_PREFIXinstead of/$SWIFT_PREFIXis/opt/swift/{version number}by default.PATH="${SWIFT_PREFIX}/usr/bin:${PATH}"andLD_LIBRARY_PATH="${SWIFT_PREFIX}/usr/lib/swift/linux"$SWIFT_PREFIX/usr/bin/*to/usr/bin/*for existing users who expectswiftto be in/usr/bin.