-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile for Debian 10/buster #169
Conversation
unzip \ | ||
vim \ | ||
uuid-dev \ | ||
ca-certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @schafdog this is awesome. did you review all the above to make sure it the minimal set. for example I am a tad surprised to see vim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not at all optimized to be minimal. There was already a debian 9 dockerfile that I based 10 upon. Doing a manual build in the container I saw that just doing git clone failed due to missing CA certificates, which I added. I believe it did build after that.
Still a bit insecure on how to "prove" that the dockerfile / image would work 100% to build the full toolchain and run the tests. Kind of interested in taking it all the way to debian packages, but can't say I have much experience in this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding guide for local testing in #171
@@ -30,7 +30,8 @@ RUN apt -y install \ | |||
tzdata \ | |||
unzip \ | |||
vim \ | |||
uuid-dev | |||
uuid-dev \ | |||
ca-certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth noting that the Debian 9 dockerfile is still one we are working on, hence we did not publish toolchain for debian yet.
that's nice, would that also help with the ubuntu docker files? maybe separate PR if true |
I think it is included in another PR for the ubuntu build: #158 Image went from from 1GB to 675MB |
@swift-ci Please test |
@swift-ci test |
hi @schafdog did you have a chance to look into the feedback? |
The Swift project moved the default branch to More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412 |
Based on Debian 9 but added option --no-install-recommends which make the image size go from 1.07GB to 843MB